Replace timeouts. Instead, use Contexts with Deadlines/Timeouts #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will be good, go ahead and keep doing what youre doing! |
added 4 commits
September 1, 2014 20:58
sender will panic when attempting to send on closed channel https://groups.google.com/forum/#!msg/golang-nuts/pZwdYRGxCIk/qpbHxRRPJdUJ
|
With upcoming changes to the network layer, the bitswap refactoring has gone in a somewhat different direction. Closing this PR. Check #65 for info about the |
ribasushi
pushed a commit
that referenced
this pull request
Jul 4, 2021
This was messing with the line numbers. It was reported and fixed in #33 but that PR isn't formatted. closes #33 (all credit goes to @jiangsong)
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Remove clientOnly as per ipfs#26
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…ocks Add strategic provider system experiment flag
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…der-system-no-blocks Add strategic provider system experiment flag
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…der-system-no-blocks Add strategic provider system experiment flag
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…der-system-no-blocks Add strategic provider system experiment flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbenet @whyrusleeping
This PR marks the beginning of some
timeoutrefactoring. If this is a desirable course of action, I will follow up this first commit with commits that completely replace thetimeoutwith thecontext. At the "leaves" where timeouts are actually handled, I intend to have actors listen on<-ctx.Done()and handleCanceledandDeadlineExceedederrors as appropriate. Let me know what you think.Also: regarding imports, is there a preferred order for vendored packages versus internal packages?