Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dns help with a correct domain name #3087

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Update dns help with a correct domain name #3087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/commands/dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This command resolves those links to the referenced object.

For example, with this DNS TXT record:

> dig +short TXT ipfs.io
> dig +short TXT _dnslink.ipfs.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change does not need to happen. it can be either. I'm not sure we want it to happen.

the documentation reads "with this X, then Y" it does not require a working DNS record, and it could use example.com instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want a broken example? I don't understand?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working example is much better than dummy one, example.com is nice because it works, you can fetch A record of it, you can open it via HTTP, but it won't work in this case.

dnslink=/ipfs/QmRzTuh2Lpuz7Gr39stNr6mTFdqAghsZec1JoUnfySUzcy

The resolver will give:
Expand Down