Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/commands/config: do not show private key on local network #2957

Merged
merged 9 commits into from
Jul 16, 2016
Merged

core/commands/config: do not show private key on local network #2957

merged 9 commits into from
Jul 16, 2016

Commits on Jul 13, 2016

  1. core/cmds/config: do not show privkey on the network 

    License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    011a546 View commit details
    Browse the repository at this point in the history

  2. test/sharness: add more tests against exposing PrivKey on network 

    and replacing config.

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    ea9327d View commit details
    Browse the repository at this point in the history

  3. core/commands/config: error out if config replace contains privkey 

    License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    2b682f9 View commit details
    Browse the repository at this point in the history

  4. core/commands: do not show PrivKey in config if it is null 

    License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    2fded41 View commit details
    Browse the repository at this point in the history

  5. test/sharness: make sure the string isn't empty 

    License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    f7e6590 View commit details
    Browse the repository at this point in the history

  6. cmd: include case where PrivKey is stored in lower case 

    License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    6b97588 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2016

  1. style: decapitalize error names 

    License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    @Kubuxu
    Kubuxu committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    921ae0e View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. type check to avoid panic 

    License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
    @whyrusleeping
    whyrusleeping committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    c5318e8 View commit details
    Browse the repository at this point in the history

  2. another type check fix and add back a missing test 

    License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
    @whyrusleeping
    whyrusleeping committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    7270556 View commit details
    Browse the repository at this point in the history