update protocol IDs to use versioned strings #2704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #1549 |
| } else { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
i dont understand why this is needed? adding more protocols should be the same as using ... ohhh i get it, if our first connecting fails, we issue a read to check if what we sent is bad-- hence use a different one? Wonder if paying to cost of 1RTT is better or worse than opening 2 streams simultaneously and closing one afterward.... hmmmmmmmmm decisions.
|
@jbenet we might be able to get better perf here by somehow exposing multiple protocol selection (like we get at the multistream layer). That way we can do something like: s, proto, err := host.NewStreamWithProtos(ctx, peer, ProtocolBitswap, ProtocolBitswapOld) |
whyrusleeping
force-pushed
the
fix/mstream-ids
branch
from
ab5dad9
to
1fb2299
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
fix/mstream-ids
branch
from
1fb2299
to
255c6f3
Compare
5 tasks
Closed
|
closing in favor of #3132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@diasdavid this should work for you. Mind trying out this branch against your code?
License: MIT
Signed-off-by: Jeromy why@ipfs.io