assert that you must build from inside your gopath #2399
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
fix/assert-gopath
branch
from
dd3c42c
to
cdea07d
Compare
|
This doesn't support the case where you link go-ipfs into GOPATH instead of working within GOPATH. Something like |
|
Otherwise agree this is an improvement -- have helped a few people with this in the past |
|
@lgierth good point, i'll use that |
…dling License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
@lgierth it looks like realpath isnt installed on travis :( |
|
Mmh you could pass it in from the Makefile, so that it uses make's realpath |
| #!/bin/sh | ||
|
|
||
| if [ -z "$GOPATH" ]; then | ||
| echo "GOPATH not set, you must have go configured properly to install ipfs" |
There was a problem hiding this comment.
. You
Note: @whyrusleeping you use commas a lot more than they should be used. In cases like this, use a period.
There was a problem hiding this comment.
but, i like, commas
There was a problem hiding this comment.
Yes, but it doesn't come off the right way. You use them to divide up independent clauses, which ain't right.
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
assert that you must build from inside your gopath
Make sure that the user cloned the code to the correct place, this is useful since go is very strict about paths.
cc @chriscool for some code review and @RichardLitt for doc stuff
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com