Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalized could #2330

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Capitalized could #2330

merged 1 commit into from
Feb 11, 2016

Conversation

RichardLitt
Copy link
Member

Seemed smart.

@RichardLitt RichardLitt added topic/docs-ipfs Topic docs-ipfs exp/novice Someone with a little familiarity can pick up need/review Needs a review labels Feb 11, 2016
@GitCop
Copy link

GitCop commented Feb 11, 2016

There were the following issues with your Pull Request

  • Commit: 79aa420
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@RichardLitt
Capitalized could
59a98a8 
License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
@GitCop
Copy link

GitCop commented Feb 11, 2016

There were the following issues with your Pull Request

  • Commit: 79aa420
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@RichardLitt
Copy link
Member Author

I installed the darn thing, what's your malfunction @GitCop

@dignifiedquire
Copy link
Member

@RichardLitt enjoying gitcop? ;)

@whyrusleeping
Copy link
Member

@GitCop go home, youre drunk.

This LGTM

whyrusleeping added a commit that referenced this pull request Feb 11, 2016
@whyrusleeping
Merge pull request #2330 from ipfs/feature/capitalize-could
9fbe3d1 
Capitalized could
@whyrusleeping whyrusleeping merged commit 9fbe3d1 into master Feb 11, 2016
@whyrusleeping whyrusleeping deleted the feature/capitalize-could branch February 11, 2016 18:33
@RichardLitt RichardLitt mentioned this pull request Feb 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up need/review Needs a review topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichardLitt @GitCop @dignifiedquire @whyrusleeping