Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t0020: cleanup dir with bad perms #2040

Merged
merged 1 commit into from
Dec 6, 2015
Merged

t0020: cleanup dir with bad perms #2040

merged 1 commit into from
Dec 6, 2015

Conversation

chriscool
Copy link
Contributor

This is needed on OSX otherwise the trash directory for the
t0020-init.sh test fails to be removed due to a permissions
error.

This fixes issue #2026.

License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org

This is needed on OSX otherwise the trash directory for the
t0020-init.sh test fails to be removed due to a permissions
error.

This fixes #2026

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@jbenet jbenet added the status/in-progress In progress label Dec 5, 2015
@whyrusleeping
Copy link
Member

wooo! 👍

@chriscool
Copy link
Contributor Author

The Travis-CI/pr build failure is in t0230 and doesn't look related:

expecting success: 

        mkdir -p testdir &&

        echo "hello test" >testdir/test.txt &&

        ipfs add -r testdir &&

        curl -i "http://localhost:$PORT_API/api/v0/refs?arg=QmTcJAn3JP8ZMAKS6WS75q8sbTyojWKbxcUHgLYGWur4Ym&stream-channels=true&encoding=text" >actual_output



No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

@ghost
Copy link

ghost commented Dec 6, 2015

👏 👏 👏

@jbenet
Copy link
Member

jbenet commented Dec 6, 2015

@chriscool this LGTM. thanks!

jbenet added a commit that referenced this pull request Dec 6, 2015
@jbenet jbenet merged commit 9066b12 into master Dec 6, 2015
@jbenet jbenet removed the status/in-progress In progress label Dec 6, 2015
@jbenet jbenet deleted the t0020-fix-osx-dir-perms branch December 6, 2015 05:54
@jbenet jbenet mentioned this pull request Dec 7, 2015
14 tasks
@chriscool chriscool mentioned this pull request Dec 16, 2015
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants