correct the blocksize calculation for link blocks #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh it's in bytes! and the tests need fixing (chunking changed) |
|
thats weird... the hash for the 5MB random file changed... which doesnt make sense. |
|
why not? maybe it was chunked to multiple indirect blocks and not to less. |
|
5MB/256k = 20 8K/(258+3 + 5) = 30 |
|
Ah, okay, its the 100MB test thats failing. makes a lot more sense |
|
Aw man, i just found the perfect gif: i guess it still works. |
|
the day when your gifs are hosted in ipfs will be a good one |
update hash for bigfile
whyrusleeping
force-pushed
the
fix/blocksize-calc
branch
from
942a403 to
95f0153
Compare
jbenet
added a commit
that referenced
this pull request
May 6, 2015
correct the blocksize calculation for link blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been wrong for a while, and ive known about it for a while, but i finally decided to fix it.