Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object links command is broken on master branch #5458

Closed
rob-deutsch opened this issue Sep 13, 2018 · 4 comments · Fixed by #5459
Closed

Object links command is broken on master branch #5458

rob-deutsch opened this issue Sep 13, 2018 · 4 comments · Fixed by #5459
Assignees
@Stebalien
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@rob-deutsch
Copy link
Contributor

Version information:

go-ipfs version: 0.4.18-dev-
Repo version: 7
System version: amd64/darwin
Golang version: go1.10.3

Type:

Bug

Description:

My apologies, I don't know if I should be reporting bugs on the master branch, but I noticed that ipfs object links isn't working. See reproduction steps:

$ ipfs object get QmYhHUDK28dU5QJnMnPwGU8gCUxegdcA5LkHjNU1ikbwWY
{"Links":[{"Name":"bigfile","Hash":"QmSkLz9P64rK8gwPw9JWN8FDBkJEP2x5W48DFJ4JjVB2nr","Size":102424431},{"Name":"smallfile","Hash":"QmNnfArfVAabiCgQKeE2cNi7CfYScX5BgHyvNRdJUSWehB","Size":61}],"Data":"\u0008\u0001"}
$ ipfs object links QmYhHUDK28dU5QJnMnPwGU8gCUxegdcA5LkHjNU1ikbwWY
01:19:33.729 ERROR   cmds/lgc: expected type *objectcmd.Object, got objectcmd.Object command.go:41
$
@overbool
Copy link
Contributor

overbool commented Sep 13, 2018 •
edited
Loading

@rob-deutsch I can't reproduce your bug, did you do anything else?

@rob-deutsch
Copy link
Contributor Author

Weird! I can't replicate it either now!

Closing for now on the assumption that I did something silly without realising.

@Stebalien Stebalien reopened this Sep 13, 2018
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Sep 13, 2018
@Stebalien
Copy link
Member

No, this is a bug that only happens when the daemon is in offline mode.

Stebalien added a commit that referenced this issue Sep 13, 2018
@Stebalien
fix output of object command
2a0af78 
We're expecting a pointer, not a value. This works in daemon mode but not in
offline mode.

fixes #5458

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Sep 13, 2018
Merged
@ghost ghost assigned Stebalien Sep 13, 2018
@ghost ghost added the status/in-progress In progress label Sep 13, 2018
@ghost ghost removed the status/in-progress In progress label Sep 13, 2018
@rob-deutsch
Copy link
Contributor Author

Thanks @Stebalien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix output of object command ipfs/kubo
3 participants
@Stebalien @rob-deutsch @overbool