Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better document targets in make output #4647

Closed
kevina opened this issue Feb 4, 2018 · 3 comments
Closed

Better document targets in make output #4647

kevina opened this issue Feb 4, 2018 · 3 comments

Comments

@kevina
Copy link
Contributor

kevina commented Feb 4, 2018

From my comments on #4645:

You might want to add test_go_test under TESTING TARGETS (when you type just make) and explain what test_go_expensive does.

Just a suggestion, only creating this issue to make sure my comment was not lost in the noise as that p.r was merged without my comment being acknowledged.
Stebalien added a commit that referenced this issue Feb 4, 2018
@Stebalien
document make targets
30b8fa0 
fixes #4647

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member

You might want to add test_go_test under TESTING TARGETS

test_go_test is an internal target and probably shouldn't be called directly. However, yes, these targets should all be documented.

@Stebalien Stebalien mentioned this issue Feb 5, 2018
Merged
@kevina
Copy link
Contributor Author

kevina commented Feb 5, 2018

test_go_test is an internal target and probably shouldn't be called directly.

It would be nice to have a documented target that runs all the go tests without anything else just to keep things uniform.

@Stebalien
Copy link
Member

@kevina fair enough. Done.

AFDudley pushed a commit to vulcanize/go-ipfs that referenced this issue Mar 22, 2018
@Stebalien @AFDudley
document make targets
47bafd2 
fixes ipfs#4647

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @kevina