Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GOOS to build on all platforms #4427

Closed
Stebalien opened this issue Nov 25, 2017 · 3 comments · Fixed by #4445
Closed

Use GOOS to build on all platforms #4427

Stebalien opened this issue Nov 25, 2017 · 3 comments · Fixed by #4445
Assignees
@Stebalien

Comments

@Stebalien
Copy link
Member

make test_short (and CI builds) should try building on other operating systems to make sure that ipfs at least builds. That is, we should run, e.g., GOOS=windows go build in cmd/ipfs.
@Stebalien Stebalien mentioned this issue Nov 25, 2017
Merged
@whyrusleeping
Copy link
Member

we used to do this: https://github.com/ipfs/go-ipfs/pull/2611/files

@Stebalien
Copy link
Member Author

Removed in #3504. @Kubuxu?

@Kubuxu
Copy link
Member

Kubuxu commented Nov 29, 2017

Looks like it: https://github.com/ipfs/go-ipfs/pull/3504/files#diff-b67911656ef5d18c4ae36cb6741b7965L148

It was not being used by CI as we never run this target AFAIK.

@Stebalien Stebalien self-assigned this Nov 29, 2017
Stebalien added a commit that referenced this issue Dec 1, 2017
@Stebalien
build for all supported platforms when testing
6917d2f 
fixes #4427

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Dec 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build for all supported platforms when testing ipfs/kubo
3 participants
@Stebalien @whyrusleeping @Kubuxu