Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test failure in bitswap #4108

Open
Stebalien opened this issue Jul 31, 2017 · 4 comments · Fixed by #4109
Open

Random test failure in bitswap #4108

Stebalien opened this issue Jul 31, 2017 · 4 comments · Fixed by #4109
Labels
topic/bitswap Topic bitswap topic/test failure Topic test failure

Comments

@Stebalien
Copy link
Member

Version information:

go-ipfs version: 0.4.11-dev-06c567d17
Repo version: 5
System version: amd64/linux
Golang version: go1.8.3

Type:

Bug

Severity:

Medium

Description:

ERROR   bitswap: nil cid in GetBlock get.go:18

--- FAIL: TestBasicBitswap (0.03s)

	bitswap_test.go:319: Test a one node trying to get one block from another

	bitswap_test.go:338: should have no items in other peers wantlist

FAIL

FAIL	github.com/ipfs/go-ipfs/exchange/bitswap	10.387s
@Stebalien Stebalien mentioned this issue Jul 31, 2017
Closed
@Stebalien Stebalien added topic/bitswap Topic bitswap kind/bug A bug in existing code (including security flaws) topic/test failure Topic test failure and removed kind/bug A bug in existing code (including security flaws) labels Jul 31, 2017
@Stebalien
Copy link
Member Author

I believe this is simply a race in the tests. Fix incoming.

Stebalien added a commit that referenced this issue Jul 31, 2017
@Stebalien
bitswap_test: make racy test less racy
f613fba 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Jul 31, 2017
Merged
Stebalien added a commit that referenced this issue Jul 31, 2017
@Stebalien
bitswap_test: make racy test less racy
bc1d896 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 31, 2017
@Stebalien
bitswap_test: make racy test less racy
6f9cbf7 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Aug 1, 2017
@Stebalien
bitswap_test: make racy test less racy
64c50be 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Aug 16, 2017
@Stebalien
bitswap_test: make racy test less racy
363db49 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Aug 17, 2017
@Stebalien
bitswap_test: make racy test less racy
fb1e7c0 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Aug 17, 2017
@Stebalien
bitswap_test: make racy test less racy
c93b52b 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Aug 17, 2017
@Stebalien
bitswap_test: make racy test less racy
8d5f3f4 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Aug 17, 2017
@Stebalien
bitswap_test: make racy test less racy
67c572e 
fixes #4108

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

#4411 😭

@Stebalien Stebalien reopened this Nov 21, 2017
@Stebalien Stebalien mentioned this issue Nov 21, 2017
Merged
@Stebalien
Copy link
Member Author

Stebalien commented Dec 15, 2017 •
edited
Loading

Race races are racy. Use locks.

@Stebalien Stebalien mentioned this issue Dec 15, 2017
Merged
@Stebalien
Copy link
Member Author

Nope. There were races, but this bug isn't related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/bitswap Topic bitswap topic/test failure Topic test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bitswap_test: make racy test less racy ipfs/kubo
1 participant
@Stebalien