[WIP] feat: migrate to TS #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Potsides <alex@achingbrain.net>
|
Thanks for working on this. I think the conversion may have been a lot more straight forward without trying to also integrate the changes from #764. This module is already ESM and already has types everywhere so it should be a case of just renaming the files, updating the config in |
|
superseded by #777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP and not something I plan to spend more time on, but I wanted to open up this PR so others (Alex?) could benefit from the work I've already done.
Based off of #764 and currently failing esbuild due to node platform issues. @achingbrain feel free to close if not useful.