-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add js-kubo-rpc-client #764
Changes from 22 commits
20ea2f9
cb0e10b
7fa9e7e
3b775f0
ee3b36a
60c2c84
004ebc6
b828341
e4e8bb5
3db2fb5
ab88fed
0ed3917
9eb0b51
8de4a2d
68673b8
48adc63
cb4c373
5783286
2f98a0b
3a78c13
feadf53
86aec67
919e03f
0635198
d1fa4c0
baa5ffb
d3afe62
30db4db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ logs | |
*.log | ||
|
||
coverage | ||
.coverage | ||
|
||
# Runtime data | ||
pids | ||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -22,25 +22,9 @@ | |||
}, | ||||
"type": "module", | ||||
"types": "./dist/src/index.d.ts", | ||||
"typesVersions": { | ||||
"*": { | ||||
"*": [ | ||||
"*", | ||||
"dist/*", | ||||
"dist/src/*", | ||||
"dist/src/*/index" | ||||
], | ||||
"src/*": [ | ||||
"*", | ||||
"dist/*", | ||||
"dist/src/*", | ||||
"dist/src/*/index" | ||||
] | ||||
} | ||||
}, | ||||
"files": [ | ||||
"src", | ||||
"dist", | ||||
"dist/src", | ||||
"!dist/test", | ||||
"!**/*.tsbuildinfo" | ||||
], | ||||
|
@@ -142,11 +126,13 @@ | |||
] | ||||
}, | ||||
"scripts": { | ||||
"clean": "aegir clean", | ||||
"lint": "aegir lint", | ||||
"dep-check": "aegir dep-check", | ||||
"build": "aegir build", | ||||
"test": "aegir test", | ||||
"test:node": "aegir test -t node", | ||||
"test:chrome": "aegir test -t browser", | ||||
"test:node": "aegir test -t node --cov", | ||||
"test:chrome": "aegir test -t browser --cov", | ||||
"test:firefox": "aegir test -t browser -- --browser firefox", | ||||
"release": "aegir release" | ||||
}, | ||||
|
@@ -166,19 +152,21 @@ | |||
"wherearewe": "^2.0.1" | ||||
}, | ||||
"devDependencies": { | ||||
"@libp2p/interfaces": "^3.0.3", | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This dep is added but doesn't appear to be used anywhere?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When removing this, ipfs-core-types throws an error There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @SgtPooki : a couple of thoughts:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pushing up a change removing this to see if CI still passes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @BigLep thanks for chiming in. I was keeping an eye out for the error. I did already comment on the file changes with the error. I was going to share it in the CI if seen there, but it looks like it's going to pass |
||||
"@types/hapi__hapi": "^20.0.9", | ||||
"aegir": "^37.0.15", | ||||
"go-ipfs": "^0.15.0", | ||||
"ipfs": "^0.64.0", | ||||
"ipfs-client": "^0.9.0", | ||||
"ipfs-core-types": "^0.12.0", | ||||
"ipfs-http-client": "^58.0.0", | ||||
"kubo-rpc-client": "^1.0.1", | ||||
"util": "^0.12.4" | ||||
}, | ||||
"browser": { | ||||
"./src/endpoint/server.js": "./src/endpoint/server.browser.js", | ||||
"./src/utils.js": "./src/utils.browser.js", | ||||
"./src/ipfsd-daemon.js": "./src/ipfsd-client.js", | ||||
"./dist/src/endpoint/server.js": "./dist/src/endpoint/server.browser.js", | ||||
"./dist/src/utils.js": "./dist/src/utils.browser.js", | ||||
"./dist/src/ipfsd-daemon.js": "./dist/src/ipfsd-client.js", | ||||
"go-ipfs": false | ||||
}, | ||||
"jsdelivr": "dist/index.min.js", | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this,
ipfs-core-types
was failing on a lack of types from@libp2p/interfaces/events
from the lineimport type { EventHandler } from '@libp2p/interfaces/events'