Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change to ipfs-http-client #311

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Conversation

hugomrdias
Copy link
Member

tests still not passing

ipfsd.api for Daemons
    go
      1) test the ipfsd.api
(node:2935) UnhandledPromiseRejectionWarning: AssertionError: expected [Error: Command failed: /Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/go-ipfs-dep/go-ipfs/ipfs daemon
Error: serveHTTPApi: manet.Listen(/ip4/127.0.0.1/tcp/5101) failed: listen tcp4 127.0.0.1:5101: bind: address already in use

Initializing daemon...
go-ipfs version: 0.4.18-
Repo version: 7
System version: amd64/darwin
Golang version: go1.11.1
Swarm listening on /ip4/127.0.0.1/tcp/50306
Swarm listening on /p2p-circuit
Swarm announcing /ip4/127.0.0.1/tcp/50306
Received interrupt signal, shutting down...
(Hit ctrl-c again to force-shutdown the daemon.)
] to not exist
    at df.spawn (/Users/hugomrdias/code/pl/js-ipfsd-ctl/test/api.spec.js:99:28)
    at series (/Users/hugomrdias/code/pl/js-ipfsd-ctl/src/factory-daemon.js:136:25)
    at /Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/async/internal/parallel.js:39:9
    at /Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/async/internal/once.js:12:16
    at iterateeCallback (/Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/async/internal/eachOfLimit.js:45:17)
    at /Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/async/internal/onlyOnce.js:12:16
    at /Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/async/internal/parallel.js:36:13
    at f (/Users/hugomrdias/code/pl/js-ipfsd-ctl/node_modules/once/once.js:25:25)
    at command.then.catch.err (/Users/hugomrdias/code/pl/js-ipfsd-ctl/src/utils/exec.js:30:7)
    at process._tickCallback (internal/process/next_tick.js:68:7)

@hugomrdias hugomrdias requested a review from alanshaw November 28, 2018 13:47
@ghost ghost assigned hugomrdias Nov 28, 2018
@ghost ghost added the status/in-progress In progress label Nov 28, 2018
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost assigned alanshaw Nov 28, 2018
@hugomrdias hugomrdias changed the title [WIP] feat: change to ipfs-http-client feat: change to ipfs-http-client Nov 28, 2018
hugomrdias and others added 2 commits November 28, 2018 16:02
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@hugomrdias hugomrdias force-pushed the feat/change-to-http-client branch from 79aabba to ad2587c Compare November 28, 2018 16:02
@hugomrdias hugomrdias merged commit 412c18f into master Nov 28, 2018
@hugomrdias hugomrdias deleted the feat/change-to-http-client branch November 28, 2018 16:56
@ghost ghost removed the status/in-progress In progress label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants