Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix(ipfs-core-types): top OptionExtension #3749

Closed
wants to merge 1 commit into from
Closed

fix(ipfs-core-types): top OptionExtension #3749

wants to merge 1 commit into from

Conversation

bluelovers
Copy link
Contributor

No description provided.

@achingbrain
Copy link
Member

Thanks for opening this and the other PRs.

You haven't added a description so it's unclear why you wish to make the change so it's hard to review. It's causing CI failures so it cannot be merged without further work.

Can you please for this and all future PRs, add a description that clearly states:

  1. The problem you perceive
  2. How your solution addresses the problem
  3. Any potential problems with your solution or tradeoffs - breaking changes, etc

@lidel lidel added the need/author-input Needs input from the original author label Jul 23, 2021
This was referenced Jul 27, 2021
Closed
Merged
achingbrain added a commit that referenced this pull request Jul 27, 2021
@achingbrain
fix: export ipfs http client type and use option extension for client (…
31bddd4 
…#3763)

Bubbles the `OptionExtension` up to the root type for use by the HTTP client and exports an interface for use by consuming modules.

Supersedes #3749 and #3736
@achingbrain
Copy link
Member

Fixed by #3763

SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
@achingbrain
fix: export ipfs http client type and use option extension for client…
4a7a810 
… (#3763)

Bubbles the `OptionExtension` up to the root type for use by the HTTP client and exports an interface for use by consuming modules.

Supersedes #3749 and #3736
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
need/author-input Needs input from the original author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluelovers @achingbrain @lidel