Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: libp2p 0.29 integration #3237

Closed
wants to merge 1 commit into from
Closed

Conversation

vasco-santos
Copy link
Member

This PR integrates libp2p@0.29 into js-ipfs. The main features included are the usage of Signed Peer Records in Identify and Gossipsub1.1 as described in libp2p/js-libp2p#654

(we might potentially add the UInt8Array refactor here)

@achingbrain
Copy link
Member

I’ve done this as part of #2771 - just need the libp2p interop PRs merged to finish the libp2p part, then bitswap can be finished the last of the github dep URLs removed.

@vasco-santos
Copy link
Member Author

@achingbrain do you mean the UInt8Array stuff?
Anyway, I needed to test gossipsub interop via IPFS and I eventually need to handle a pubsub breaking change here

@vasco-santos
Copy link
Member Author

vasco-santos commented Aug 21, 2020

Also FYI we need to sync next week about libp2p/js-libp2p#730 + 0.29, because the 0.29 also has things that need to be changed to UintArray and if we want to get everything in 0.29, we need to make sure that it is also changed

EDIT: There will be no breaking change in pubsub. So, we can bump the pubsub and libp2p with #2771 if it is better

@achingbrain
Copy link
Member

#2771 has the libp2p 0.29.0 branch as it's dep version and seems happy, so I guess we can call that the integration PR?

@vasco-santos
Copy link
Member Author

@achingbrain yes, I will close this PR! I also wanted to check interop tests here with gossipsub1.1 both in go and js, which are cool

@achingbrain achingbrain deleted the chore/libp2p-0.29 branch August 25, 2020 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants