This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: allow controlling preload behaviour from cli #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Should this be exposed in the HTTP API? Otherwise this won't work when talking to a daemon. Also, should |
achingbrain
force-pushed
the
add-preload-cli-arg
branch
from
20c609e
to
69d746f
Compare
Good point, I have added this.
Not sure. I guess maybe if you've specified it explicitly? |
|
Exposed in |
Just looked in the preload component and this happens already. If you start the daemon with |
alanshaw
approved these changes
Aug 23, 2019
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #2379
Depends on: