-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@@ -62,7 +62,7 @@ | |||
}, | |||
"homepage": "https://github.com/ipfs/js-ipfs#readme", | |||
"devDependencies": { | |||
"aegir": "^17.0.1", | |||
"aegir": "^17.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can update aegir
now to 18.0.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to hold off on that one for this release and do that upgrade in 0.35
@alanshaw the test failures with handling control signals is due to Event Emitter Warnings being registered as test errors. Without resolving the underlying emitter warnings, we could either pass Since code didn't change before this started occurring it's likely due to a patch dependency update adding another listener somewhere. |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@jacobheun it would be awesome if you have a moment to eyeball 60dc0db - it's fallout from libp2p/js-libp2p-bootstrap#86 |
@alanshaw the fix looks reasonable, nice to see we're discovering peers so quickly :). Moving the event listener outside |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
I'm going to get this merged as it'll fix master. Windows CI failure is known occasional issue "Database is not open" - unrelated to the changes here. |
No description provided.