Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: update deps #1803

Merged
merged 7 commits into from
Jan 15, 2019
Merged

chore: update deps #1803

merged 7 commits into from
Jan 15, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 3, 2019

No description provided.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@ghost ghost assigned alanshaw Jan 3, 2019
@ghost ghost added the status/in-progress In progress label Jan 3, 2019
Alan Shaw added 2 commits January 4, 2019 13:12
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@@ -62,7 +62,7 @@
},
"homepage": "https://github.com/ipfs/js-ipfs#readme",
"devDependencies": {
"aegir": "^17.0.1",
"aegir": "^17.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can update aegir now to 18.0.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to hold off on that one for this release and do that upgrade in 0.35

@jacobheun
Copy link
Contributor

@alanshaw the test failures with handling control signals is due to Event Emitter Warnings being registered as test errors. Without resolving the underlying emitter warnings, we could either pass NODE_NO_WARNINGS=1 to the execa call for the test suite, or do something along the lines of f894a3f, to log out the warnings and continue with the test so we at least are getting visibility to those issues.

Since code didn't change before this started occurring it's likely due to a patch dependency update adding another listener somewhere.

Alan Shaw added 2 commits January 14, 2019 15:50
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
Copy link
Member Author

@jacobheun it would be awesome if you have a moment to eyeball 60dc0db - it's fallout from libp2p/js-libp2p-bootstrap#86

@jacobheun
Copy link
Contributor

@alanshaw the fix looks reasonable, nice to see we're discovering peers so quickly :). Moving the event listener outside peer:discovery is definitely an improvement.

Alan Shaw added 2 commits January 15, 2019 09:52
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
Copy link
Member Author

I'm going to get this merged as it'll fix master. Windows CI failure is known occasional issue "Database is not open" - unrelated to the changes here.

@alanshaw alanshaw merged commit 6de6adf into master Jan 15, 2019
@ghost ghost removed the status/in-progress In progress label Jan 15, 2019
@alanshaw alanshaw deleted the chore/update-deps-20190103 branch January 15, 2019 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants