This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: add debug logging to http server #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up Hapi's debug logging when DEBUG env var is present. This will enable developers to see what is happening inside the daemon when ipfs/js-ipfsd-ctl#270 is merged instead of just getting error messages like 'Please retrace your steps'. It lets you do this sort of thing: ``` $ DEBUG=ipfsd-ctl:daemon:* npm test ``` ...and see Hapi's request/server logs in the output.
ghost
assigned 
daviddias
approved these changes
Jun 20, 2018
vasco-santos
approved these changes
Jun 20, 2018
alanshaw
approved these changes
Jun 20, 2018
|
@wraithgar, would you mind looking into why we're sometimes getting failures on the bitswap tests: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs/detail/PR-1403/1/pipeline/22#step-212-log-213 |
|
Looks like it's picking up a few partners in the short time the tests are running. I'll make a PR amending that test to check for everything but the partners count. ETA: PR here #1404 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up Hapi's debug logging when DEBUG env var is present.
This will enable developers to see what is happening inside
the daemon when ipfs/js-ipfsd-ctl#270 is merged instead of just
getting error messages like 'Please retrace your steps'.
It lets you do this sort of thing:
...and see Hapi's request/server logs in the output.