Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs version flags and ipfs repo version #1199

Merged
merged 8 commits into from
Feb 1, 2018

Conversation

JonKrone
Copy link
Contributor

@JonKrone JonKrone commented Jan 30, 2018

original: #1181

This implements ipfs repo version and the --all, --repo, --number, and --commit (partially) flags for ipfs version.

ipfs version --all output looks like:

$ js-ipfs version --all
js-ipfs version: 0.27.7-
Repo version: 6
System version: x64/win32
Node.js version: v8.5.0

I'm having trouble running sharness tests, am hoping that CI will point out any issues there.

Would love any feedback :)

@daviddias daviddias changed the base branch from master to pr1181 January 30, 2018 18:45
@JonKrone
Copy link
Contributor Author

JonKrone commented Jan 30, 2018

The only piece failing in Travis is related to pubsub multiple nodes connected load tests.
https://travis-ci.org/ipfs/js-ipfs/jobs/335334597#L4362. I've seen it before and believe it's a CI issue.

@daviddias
Copy link
Member

woot! This makes it. The failing test is unrelated with this PR. Thanks so much for pushing this @JonKrone :)

@daviddias daviddias merged commit 62fd639 into ipfs:pr1181 Feb 1, 2018
@JonKrone JonKrone deleted the jkrone/pr1181 branch February 1, 2018 19:34
JonKrone added a commit that referenced this pull request Feb 16, 2018
JonKrone added a commit that referenced this pull request Feb 16, 2018
daviddias pushed a commit that referenced this pull request Feb 17, 2018
daviddias pushed a commit that referenced this pull request Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants