Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

mtime and mode not set when piping from stdin #2763

Closed
alanshaw opened this issue Feb 10, 2020 · 0 comments · Fixed by #2832
Closed

mtime and mode not set when piping from stdin #2763

alanshaw opened this issue Feb 10, 2020 · 0 comments · Fixed by #2832
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@alanshaw
Copy link
Member

Stdin stream passed directly to ipfs.add

js-ipfs/src/cli/commands/add.js

Line 239 in 39d87c5

: argv.getStdin() // Pipe directly to ipfs.add

e.g.

$ echo "data" | node src/cli/bin add --mtime=100                        
added QmNtocSs7MoDkJMc1RkyisCSKvLadujPsfJfSdJ3e1eA1M QmNtocSs7MoDkJMc1RkyisCSKvLadujPsfJfSdJ3e1eA1M

$ jsipfs files stat /ipfs/QmNtocSs7MoDkJMc1RkyisCSKvLadujPsfJfSdJ3e1eA1M
QmNtocSs7MoDkJMc1RkyisCSKvLadujPsfJfSdJ3e1eA1M
Size: 5
CumulativeSize: 13
ChildBlocks: 0
Type: file
Mode: -rw-r--r--
Mtime: -
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Feb 10, 2020
kanej added a commit to kanej/js-ipfs that referenced this issue Mar 6, 2020
@kanej
fix: tag stdin with mtime and mode when piping to cli 'add'
78c9055 
Converts the stdin stream to a async iterator of one file and tags that file with the mtime and
mode.

fixes ipfs#2763
@kanej kanej mentioned this issue Mar 6, 2020
Merged
kanej added a commit to kanej/js-ipfs that referenced this issue Mar 17, 2020
@kanej
fix: tag stdin with mtime and mode when piping to cli 'add'
5c21376 
Converts the stdin stream to an array of one file and tags that file with the mtime and mode.

fixes ipfs#2763
kanej added a commit to kanej/js-ipfs that referenced this issue Mar 24, 2020
@kanej
fix: tag stdin with mtime and mode when piping to cli 'add'
4a5c571 
Converts the stdin stream to file object and tags that file with the mtime and mode.

fixes ipfs#2763
kanej added a commit to kanej/js-ipfs that referenced this issue Mar 24, 2020
@kanej
fix: tag stdin with mtime and mode when piping to cli 'add'
43bf310 
Converts the stdin stream to a file object and tags it with the mtime and mode.

fixes ipfs#2763
achingbrain pushed a commit that referenced this issue Mar 25, 2020
@kanej
fix: tag stdin with mtime and mode when piping to cli 'add' (#2832)
8c97de1 
Converts the stdin stream to a file object and tags it with the mtime and mode.

fixes #2763
mistakia pushed a commit to mistakia/js-ipfs that referenced this issue Apr 3, 2020
@kanej
fix: tag stdin with mtime and mode when piping to cli 'add' (ipfs#2832)
323c29c 
Converts the stdin stream to a file object and tags it with the mtime and mode.

fixes ipfs#2763
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tag stdin with mtime and mode when piping to cli 'add' kanej/js-ipfs
1 participant
@alanshaw