This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Encoding key names with base32 #1937
Labels
Comments
Yeah, definitely. But I am actually working on migration tool here: https://github.com/AuHau/js-ipfs-repo-migrations and this will be first demonstration migration. Hopefully next week I should have first version for review. |
js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide. Please feel to reopen with any comments before 2023-06-05. We will do a final pass on reopened issues afterward (see #4336). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Type: Enhacement
Description:
As part of my PR ipfs/kubo#6012 go-ipfs will be encoding key's names into base32 in order to unify behavior across all platforms (case sensitivity). As a small bonus because of it, it will be able to use any characters for the key's names (like namespacing for example "websites/some-website").
I assume that since js-ipfs has a goal to have interoperable repositories with go-ipfs, this behavior should be propagated from go-ipfs to js-ipfs as well.
I am happy to provide PR for js-ipfs as well.
I have a few questions.
Is this desired from your side? Will you accept the PR?
My idea of implementation of it would be to create something like
EncodedDatastore
wrapper that would be used injs-ipfs-repo
for thekeys
property and would do the translation from/to base32.I believe the base32 encoding won't be necessary for the
datastore-level
, should I hardwire exception for it or also encode it?The text was updated successfully, but these errors were encountered: