-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(decision-engine): split large block messages #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a test case as well, otherwise LGTM
@victorbjelkholm updated |
@@ -35,14 +38,42 @@ class DecisionEngine { | |||
} | |||
|
|||
_sendBlocks (env, cb) { | |||
// split into messges of max 512 * 1024 bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, because of https://github.com/ipfs/go-ipfs/blob/master/exchange/bitswap/network/ipfs_impl.go#L186
We have a limit to the maximum message size you can send.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, though that is higher than the multiplex limit you implemented in go. So I'm not sure if you could run into the same issue
No description provided.