Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable countly analytics and hide unused UI #2216

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 5, 2024

This PR applies minimal changes to Close #2198 but without waiting for ipfs-shipyard/ignite-metrics#133

  • hide analytics UI components
  • stop sending broken opt-out metrics to instance which no longer works

It does not remove any code, and allows restoring analytics once we have time to do ipfs-shipyard/ignite-metrics#133.

Minimal changes to hide analytics UI components
and stop sending opt-out metrics to instance which no longer works.

Close #2198
@lidel lidel requested a review from a team as a code owner April 5, 2024 21:42
@lidel lidel mentioned this pull request Apr 5, 2024
11 tasks
@lidel
Copy link
Member Author

lidel commented Apr 8, 2024

@SgtPooki does this look ok to ship as a patch release?
Would like to make this surgical fix and include it in Kubo 0.28 or 0.29.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but we're currently setting optedOut to false

showAnalyticsBanner: false,
optedOut: false,
optedOut: !DISABLE_ALL_ANALYTICS, // disable analytics by default for now, see https://github.com/ipfs/ipfs-webui/issues/2198
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
optedOut: !DISABLE_ALL_ANALYTICS, // disable analytics by default for now, see https://github.com/ipfs/ipfs-webui/issues/2198
optedOut: DISABLE_ALL_ANALYTICS, // disable analytics by default for now, see https://github.com/ipfs/ipfs-webui/issues/2198

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to set this opted out to true for now? if not, we should probably leave as false

Copy link
Member Author

@lidel lidel Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch – my bad, I negated the wrong line. Fixed in 1e04f2e + updated tests to confirm we hide UI and do no tracking by default.

@lidel lidel force-pushed the chore/disable-and-hide-countly-analtics branch from 6f36572 to 1e04f2e Compare April 8, 2024 18:26
@lidel lidel merged commit d137048 into main Apr 8, 2024
22 checks passed
@lidel lidel deleted the chore/disable-and-hide-countly-analtics branch April 8, 2024 22:30
ipfs-gui-bot pushed a commit that referenced this pull request Apr 8, 2024
## [4.2.1](v4.2.0...v4.2.1) (2024-04-08)

 CID `bafybeigggyffcf6yfhx5irtwzx3cgnk6n3dwylkvcpckzhqqrigsxowjwe`

 ---

### Bug Fixes

* **peers:** add connection accepts valid multiaddrs ([#2199](#2199)) ([91ff2ca](91ff2ca))
* **pinning:** update scaleway logo and link ([#2194](#2194)) ([b8ac64f](b8ac64f))

### Trivial Changes

* **deps:** bump actions/cache from 3 to 4 ([#2196](#2196)) ([e131185](e131185))
* disable countly analytics and hide unused UI ([#2216](#2216)) ([d137048](d137048)), closes [#2198](#2198) [/github.com//pull/2216/files#r1556085374](https://github.com/ipfs//github.com/ipfs/ipfs-webui/pull/2216/files/issues/r1556085374)
* missed renames (api→rpc, .io→.tech) ([51b2952](51b2952))
* optimize CI caching ([#2183](#2183)) ([b8a71d9](b8a71d9))
* package-lock.json update ([#2200](#2200)) ([5abc5d0](5abc5d0))
* remove estuary ([b560f5c](b560f5c))
* Update .github/dependabot.yml [skip ci] ([f847301](f847301))
* Update .github/workflows/stale.yml [skip ci] ([03c1c89](03c1c89))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/update countly.ipfs.tech telemetry
3 participants