fix: cleanup size and bandwidth units #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up code around human readable units: - base-2 (GiB, MiB, KiB) used for file sizes to remove any unit confusion while keeping interop with 1024 mindset - base-10 (Mbps, kbps) used for network bandwith, to match what ISP are selling Closes #1778
|
This makes sense to me! |
|
👍 we looked at this for a moment during GUI triage and while nobody felt strongly about this, it makes things more consistent with storage units used in storage systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up code around human-readable units and Closes #1778:
bytes in base-2 (GiB, MiB, KiB) used for file sizes to remove any unit confusion while keeping interop with 1024 way of thinking
bits in base-10 (Mbps, kbps) used for network bandwith, to match what the number that ISP is selling:
@jessicaschilling @olizilla would appreciate sanity check from your end. What units are expected by people these days? I've heard that macOS switched sizes in Finder to base-10, is that true?