fix: work around dot in pin service name #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary workaround that maintains most of functionality and works with go-ipfs 0.8.0 Context: #1770
This adds fallback to new notation from ipfs/kubo#8096 We default to old one because new one matters only when '.' is present in the service name
lidel
force-pushed
the
fix/dot-in-service-name
branch
from
1c77960
to
4aa78ba
Compare
olizilla
added a commit
to ipfs/pinning-services-api-spec
that referenced
this pull request
Apr 30, 2021
to avoid bug in ipfs/ipfs-webui#1772
olizilla
added a commit
to ipfs/pinning-services-api-spec
that referenced
this pull request
Apr 30, 2021
|
changed on the spec too ipfs/pinning-services-api-spec#76 |
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround that maintains most of the functionality while being compatible with
pin remoteandconfigcommands in go-ipfs 0.8.0:.with_so the issue (Pinning problems when a service name includes dot #1770) never surfaces.in name was already added or is added via CLI, we disable button for enabling auto upload of MFS, because it is not possible to make it work in go-ipfs 0.8.0, but everything else works as expected (manual pinning to "nft.storage" works fine)Closes #1770 (but we will have a separate fix in go-ipfs to support
.in key names)@alanshaw just for completeness, would it be ok for you to change
nft.storagetonft-storageon https://nft.storage docs aboutpin remote service add?