fix: handle file-drop inside empty dir #1020
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you drop files inside dirs that have zero or fewer items than fills the vertical height, the drop would land on the app rather than the file list, which would cause files dropped inside the dir to be added at the root rather than the dir. This PR is a quick fix to ensure the drops handled at the app level add the files to the current dir where we are on the files page. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
ghost
assigned 
fsdiogo
reviewed
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you drop files inside dirs that have zero or fewer items than
fills the vertical height, the drop would land on the app rather
than the file list, which would cause files dropped inside the dir
to be added at the root rather than the dir.
This PR is a quick fix to ensure the drops handled at the app level
add the files to the current dir where we are on the files page.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io