Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create or rename a directory to "foo bar" (with space) #1775

Closed
Luflosi opened this issue Apr 30, 2021 · 3 comments · Fixed by #1795
Closed

Unable to create or rename a directory to "foo bar" (with space) #1775

Luflosi opened this issue Apr 30, 2021 · 3 comments · Fixed by #1795
Labels
effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Milestone

Comments

@Luflosi
Copy link
Contributor

Luflosi commented Apr 30, 2021

Describe the bug
Renaming a folder or file deletes spaces at the end of the filename while typing.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Files'
  2. Click on 'Import'
  3. Click on 'New Folder'
  4. Type 'Name with spaces'
  5. See 'Namewithspaces'
  6. Adding the spaces afterwards works since then the space is not at the end

Expected behavior
I expect to type filenames with spaces without having to go back later to actually insert them.

Desktop:

  • OS: macOS
  • Browser Safari
  • Version 14.1
@Luflosi Luflosi added the need/triage Needs initial labeling and prioritization label Apr 30, 2021
@lidel lidel changed the title Renaming a file deletes spaces at the end while typing Unable to create or rename a directory to "foo bar" (with space) May 10, 2021
@lidel lidel added effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up labels May 10, 2021
@lidel
Copy link
Member

lidel commented May 10, 2021

@Luflosi thank you for reporting this, I see this is also impacting "Import" → "New folder".
Is it something you would be interested in submitting PR for, or can we leave it for others to pick up?

@lidel lidel added status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels May 10, 2021
@Luflosi
Copy link
Contributor Author

Luflosi commented May 11, 2021

I'm not interested in submitting a PR, sorry.

I see this is also impacting "Import" → "New folder"

Yes, this is exactly what I described in the steps to reproduce since that is the easiest way to see this problem.
And presumably fixing this will also fix renaming files and folders.
The new title isn't 100% accurate since technically it is possible to create or rename a directory to "foo bar" by first typing "foobar" and then adding the space afterwards.

@lidel lidel added this to the v2.12 milestone May 15, 2021
lidel added a commit that referenced this issue May 20, 2021
Closes #1775 my moving fix from #1718 to correct place
lidel added a commit that referenced this issue May 21, 2021
Closes #1775 my moving fix from #1718 to correct place
@Luflosi
Copy link
Contributor Author

Luflosi commented May 21, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants