Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #132 #133

Merged
merged 3 commits into from
Oct 27, 2020
Merged

fix #132 #133

merged 3 commits into from
Oct 27, 2020

Conversation

godcong
Copy link
Contributor

@godcong godcong commented Sep 23, 2020

this PR makes when the local update fail, try to get the remote update file.

@welcome
Copy link

welcome bot commented Sep 23, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

quoting the suggestion of sigma67
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the timeout, otherwise LGTM.

util/utils.go Outdated
@@ -28,7 +28,8 @@ var (
return os.Remove(path)
}

InsideGUI = func() bool { return false }
InsideGUI = func() bool { return false }
ShellTimeOut = 3 * time.Minute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set this to ~5 minutes? The ideal solution would be to bail if we aren't making progress instead of setting a hard cutoff, but that's going to be a bit harder to do (although you're welcome to try to implement that).

Unfortunately, a 3m cutoff will make it impossible to update IPFS on a 1Mbps connection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien yes,i changed the commit.

quoting the suggestion of Stebalien
change timeout 3m -> 5m
@Stebalien Stebalien merged commit 952470e into ipfs:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants