-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #132 #133
fix #132 #133
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on the timeout, otherwise LGTM.
util/utils.go
Outdated
@@ -28,7 +28,8 @@ var ( | |||
return os.Remove(path) | |||
} | |||
|
|||
InsideGUI = func() bool { return false } | |||
InsideGUI = func() bool { return false } | |||
ShellTimeOut = 3 * time.Minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set this to ~5 minutes? The ideal solution would be to bail if we aren't making progress instead of setting a hard cutoff, but that's going to be a bit harder to do (although you're welcome to try to implement that).
Unfortunately, a 3m cutoff will make it impossible to update IPFS on a 1Mbps connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stebalien yes,i changed the commit.
this PR makes when the local update fail, try to get the remote update file.