Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin node-version to 18.17.1 #2662

Merged
merged 1 commit into from
Oct 10, 2023
Merged

ci: pin node-version to 18.17.1 #2662

merged 1 commit into from
Oct 10, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Oct 10, 2023

Node 18.18.0 breaks npm ci command in ipfs-desktop on Windows.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galargh I was diving down all the wrong holes here.

@SgtPooki SgtPooki merged commit 2b38528 into main Oct 10, 2023
8 checks passed
@SgtPooki SgtPooki deleted the ci/node-18-17-1 branch October 10, 2023 17:49
This was referenced Oct 10, 2023
@whizzzkid
Copy link
Contributor

Thanks @galargh 04d50a7 needed some more work, thanks for solving this :)

lidel added a commit that referenced this pull request Jun 7, 2024
This also tests  ipfs/npm-kubo#74
removing the need for hack from #2662
lidel added a commit that referenced this pull request Jun 12, 2024
* refactor: macos universal build
* refactor: switch to macos-latest (arm)
* feat(macos): build universal kubo binary
* fix(ci): switch back to lts node

This also tests  ipfs/npm-kubo#74
removing the need for hack from #2662

* chore: remove coactions/setup-xvfb

modern linux image at github includes it out of the box
and we use xvfb-maybe internally to use it when appropriate

* chore: update .github/CODEOWNERS
* chore: kubo v0.29.0
* chore: electron-updater

bumping to include:
windows fix: https://github.com/electron-userland/electron-builder/releases/tag/electron-updater%406.1.9
macos fix: https://github.com/electron-userland/electron-builder/releases/tag/electron-updater%406.2.1

* chore: ensure release as 0.36.0

Release-As: 0.36.0
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants