feat: Add app&webui ready/load metrics #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
screenshot from metrics website: |
hacdias
reviewed
May 5, 2022
|
@SgtPooki now that this is PR merged, try following steps from DEVELOPER-NOTES.md#release-checklist and create patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics around app ready, so that the branch
1177-refactor-ctx-speed-improvementscan show us how much it improves load times.Visually, it's almost instant versus an abrupt error in the first-page-load, and then a painful wait until the ipfsd daemon starts.
APP_READYcurrently shows a load time of 13.10~ seconds with this update, and I'm sure the aforementioned branch only takes 2.{\"key\":\"APP_READY\",\"count\":1,\"dur\":13.142644000053405,\"timestamp\":1651716859103,\"hour\":19,\"dow\":3}]","app_key":"REDACTED","device_id":"REDACTED","sdk_name":"javascript_native_nodejs","sdk_version":"20.11","timestamp":1651716859307,"hour":19,"dow":3}