feat: add known webui addresses to CORS conf #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
changed the title
hacdias
force-pushed
the
refactor/rm-checkCorsConfig
branch
from
ee5aac5
to
895ccd9
Compare
hacdias
force-pushed
the
feat/add-webui-cors
branch
from
02f3def
to
96b2225
Compare
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
force-pushed
the
refactor/rm-checkCorsConfig
branch
from
895ccd9
to
840a5a9
Compare
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
force-pushed
the
feat/add-webui-cors
branch
from
96b2225
to
fa6a4ab
Compare
|
Ping @lidel |
1 similar comment
|
Ping @lidel |
lidel
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #1955 for easiness.
I used the already existing
migrateConfigfunction and built on top of it. I added revision checks so we apply the migration only once.Closes ipfs/ipfs-webui#1880