Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove zip for Squirrel.Mac #1932

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix: remove zip for Squirrel.Mac #1932

merged 1 commit into from
Dec 3, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 26, 2021

WARNING to anyone reading this in the future: removing zip is not safe, – see #1922 (comment) and electron-userland/electron-builder#6496


Removing zip to fix UX issue where users are confused by "broken zip installer".

See rationale: #1922 (comment)

Closes #1922

@lidel lidel requested a review from autonome November 26, 2021 14:51
@lidel lidel merged commit ae3f40e into main Dec 3, 2021
@lidel lidel deleted the chore/remove-macos-zip branch December 3, 2021 18:56
lidel added a commit that referenced this pull request Dec 13, 2021
This reverts #1932
because of reasons desribed in
#1922 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

cannot open 0.17.0 from zip release on mac
1 participant