Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tray click events #1766

Merged
merged 1 commit into from
Feb 23, 2021
Merged

refactor: tray click events #1766

merged 1 commit into from
Feb 23, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 23, 2021 •
edited
Loading

TODO

  • linux ok
  • windows ok-ish
    • tray fixed, but entire windows experience is so bad I don't know if things are broken or just slow
    • it blows my mind that 20 years later Windows platform still has janky tray icon code: it does not disappear when you kill the process, you can get duplicate "phantom" one... 🤯 🤯 knowing its broken everywhere in some way or another makes me feel bit better about mess on linux (Tray Icon problems on Linux #1153) :trollface:

@lidel
refactor: tray click events
c606829 
- avoid `TypeError: event.preventDefault is not a function`
  (closes #1762)
- double-click opens webui (closes #17649

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel marked this pull request as ready for review February 23, 2021 19:00
@lidel lidel merged commit 1e00334 into master Feb 23, 2021
@lidel lidel deleted the fix/type-error-windows branch February 23, 2021 19:22
@mvdan
Copy link

mvdan commented Feb 23, 2021

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open app window with double-click on tray icon 0.14.0-rc1 it fails to start on Windows 10
2 participants
@lidel @mvdan