fix(ux): show dock when prompt is visible #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
lidel
reviewed
Apr 27, 2020
There was a problem hiding this comment.
This is macOS specific, and I am unable to test this.
@rafaelramalho19 mind checking?
If I understand correctly, there should be an icon in the dock when there is a prompt displayed by ipfs-desktop, and dissapear when prompt is dealed with.
You can trigger a prompt via menubar → Advanced → Run Garbage Collector
|
Just a FYI: I tested and it works. But yes, it's better if someone else checks too :) |
|
Tested and it works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show dock while the prompt is visible.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com