Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disables access to MFS functions on window.ipfs #393

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Temporarily disables access to MFS functions on window.ipfs #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions add-on/src/lib/ipfs-proxy/pre-acl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@
// All other IPFS functions require authorization.
const ACL_WHITELIST = Object.freeze(require('./acl-whitelist.json'))

// TEMPORARY blacklist of MFS functions that are automatically denied access
// https://github.com/ipfs-shipyard/ipfs-companion/issues/330#issuecomment-367651787
const MFS_BLACKLIST = Object.freeze([
'files.cp',
'files.mkdir',
'files.stat',
'files.rm',
'files.read',
'files.write',
'files.mv',
'files.flush',
'files.ls'
])

// Creates a "pre" function that is called prior to calling a real function
// on the IPFS instance. It will throw if access is denied, and ask the user if
// no access decision has been made yet.
Expand All @@ -10,6 +24,10 @@ function createPreAcl (getState, accessControl, getScope, permission, requestAcc
// Check if all access to the IPFS node is disabled
if (!getState().ipfsProxy) throw new Error('User disabled access to IPFS')

if (MFS_BLACKLIST.includes(permission)) {
throw new Error('MFS functions are temporarily disabled')
}

// No need to verify access if permission is on the whitelist
if (ACL_WHITELIST.includes(permission)) return args

Expand Down