Refactoring of Browser Action and API Polling #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces alarm-based updates with message-based signalling based on `browser.runtime.connect` API Chrome does not support Alarm intervals smaller than one minute, so we will replace all of them with this new type of signalling. This is yet another piece of #218 (and #259) efforts. This commit also closes #243 by hiding broken actions in 'incognito' mode.
It was replaced with browser.storage.onChanged listener some time ago
lidel
added
the
kind/maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had multiple issues with the way Alarms are implemented in Firefox and there are limitations under minimal interval in Chromium-based browsers.
This PR removes use of
browser.alarms.*for triggering and signaling API status changes within background script and between background script and Browser Action popup.IPFS API polling is now handled by simple Interval, and communication with Browser Action popup uses
browser.runtime.*APIs.This PR fixes #218, #259 and #243.