chore(package): bump versions and ignore package-lock.json #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to npm help package-lock.json:
My understanding is that including it in repository should finally give us deterministic builds, but please someone review this before we merge it.
PS. I know that
package-lock.json
may produce errors ifnode_modules
was already present until fix for npm/npm#16839 is released, so if you experience any issues removenode_modules
before runningnpm install
for this branch.