fix(test): 🚧 Making e2e Tests work again. #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
whizzzkid
commented
Dec 15, 2023
test/e2e/ipfs-companion.test.js
Outdated
Comment on lines
77
to
79
| // if (url.includes('landing-pages/permissions/request.html')) { | ||
| // //By.tagName is deprecated, replacement is called By.css() for some reason. | ||
| // browser.findElement(By.css('button')).click() |
There was a problem hiding this comment.
executing this code, results in:
test/e2e/ipfs-companion.test.js
Outdated
Comment on lines
211
to
215
| // - using custom profiles. | ||
| // - Clicking grant permissions button on line-74, but that results in a popup which is not interactable. | ||
| // - using capabilities (in builder section, to handler alert popups and accept all). | ||
| // https://www.selenium.dev/selenium/docs/api/javascript/module/selenium-webdriver/lib/capabilities_exports_Capabilities.html | ||
| // selenium has different interfaces for chrome permissions, e.g.: https://github.com/SeleniumHQ/selenium/blob/selenium-4.10.0/javascript/node/selenium-webdriver/test/chrome/permission_test.js#L37 |
There was a problem hiding this comment.
tried all of this, does not work.
|
@SgtPooki : can you take on reviewing this and getting it over the line? |
SgtPooki
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1300
In this PR:
host_permissionscannot be granted, yet!More in comments.