fix(release-automation): 💚 stupid hack to add tag in CI #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
reviewed
Feb 22, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
106
to
109
| - name: Tag Release | ||
| if: ${{ steps.release.outputs.release_created }} != 'true' | ||
| run: 'git tag -a v${{ steps.release.outputs.ipfs-companion--tag_name }} -m "chore(main): release ipfs-companion ${{ steps.release.outputs.ipfs-companion--tag_name }}"' | ||
|
|
There was a problem hiding this comment.
won't we have to push this tag as well?
https://github.com/search?q=org%3Aipfs+%22git+push+--tags%22&type=Code
There was a problem hiding this comment.
good catch, this would've become a head scratcher.
SgtPooki
approved these changes
Feb 22, 2023
| with: | ||
| command: manifest-pr | ||
| changelog-notes-type: github | ||
| - name: Tag Release | ||
| if: ${{ steps.release.outputs.release_created }} != 'true' | ||
| run: 'git tag -a v${{ steps.release.outputs.ipfs-companion--tag_name }} -m "chore(main): release ipfs-companion ${{ steps.release.outputs.ipfs-companion--tag_name }}" && git push origin v${{ steps.release.outputs.ipfs-companion--tag_name }}' |
There was a problem hiding this comment.
nit: you can remove the quotes and put this on multiple lines which would be much cleaner.
whizzzkid
added a commit
that referenced
this pull request
Feb 22, 2023
This reverts commit 9ea9897.
whizzzkid
added a commit
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened this issue: https://github.com/google-github-actions/release-please-action/issues/719
Not sure when will that be fixed, in the mean time, this might work.