Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-out proto.shool from the DNSLink redirect by default #921

Closed
lidel opened this issue Sep 11, 2020 · 0 comments · Fixed by #929
Closed

Opt-out proto.shool from the DNSLink redirect by default #921

lidel opened this issue Sep 11, 2020 · 0 comments · Fixed by #929
Assignees
@lidel
Labels
effort/hours Estimated to take one or several hours exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP
Milestone
v2.15

Comments

@lidel
Copy link
Member

lidel commented Sep 11, 2020 •
edited
Loading

As noted in ProtoSchool/protoschool.github.io#548 there is a need for disabling DNSLink-redirect-by-default so the users of ProtoSchool do not lose progress information store in window.localStorage, which is tied to the Origin at https://proto.school (with option to opt-in via existing "Enable" toggle in browser action)

We have opt-out list already, so the quick fix is to add one-time migration that injects proto.school to user's list. To do it in a generic way we should include app.fleek.co and perhaps slate.host too.

ps. In the long term, we should do this in a generic way to help in addressing future requests like this without the need for making a new release of IPFS Companion – perhaps loading a JSON with 'opt-out list' hosted in this very repo? Or some way for each website to define opt-out on their own? (#930)
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP exp/wizard Extensive knowledge (implications, ramifications) required effort/hours Estimated to take one or several hours labels Sep 11, 2020
@lidel lidel self-assigned this Sep 11, 2020
@lidel lidel added this to the v2.15 milestone Sep 11, 2020
@terichadbourne terichadbourne mentioned this issue Sep 14, 2020
Open
4 tasks
@lidel lidel mentioned this issue Oct 5, 2020
Merged
14 tasks
lidel added a commit that referenced this issue Oct 15, 2020
@lidel
feat: manual opt-ins and opt-outs
32b0f07 
This improves the way we handle manual opt-out performend per site by
the user by storing both manual opt-outs and opt-ins.

This way we are able to tweak implicit default per website while respecting
preexisting user choices. Also, in the future we may run opt-in metrics
that compare lengths of both lists to gain better insight into user's behavior.

Closes #921
@lidel lidel mentioned this issue Oct 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
effort/hours Estimated to take one or several hours exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
v2.15
Development

Successfully merging a pull request may close this issue.

feat: remember manual opt-ins and opt-outs per site ipfs/ipfs-companion
1 participant
@lidel