This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2018
Needs the following merging first: |
5100bd3
to
b484538
Compare
alanshaw
approved these changes
Jul 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm getting some intermittent pubsub failures which are obviously unrelated
daviddias
approved these changes
Jul 12, 2018
Also on Mac OS X with the same error.
|
594cd2e
to
d6bdedc
Compare
These are regressions caused by me trying to improve error message compatibility with go. It will need ipfs/js-ipfs#1439 merging & releasing first. |
613252b
to
c125d02
Compare
Those have been merged & released so this should be good to go, although now I think #23 is causing everything to catch fire |
c125d02
to
c4d6797
Compare
c4d6797
to
11e7f9e
Compare
1f5c1f4
to
5ea4a73
Compare
5ea4a73
to
fd10958
Compare
All of the files tests are now passing for me when run with this PR to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mfs to be merged into js-ipfs first..