feat: add record/answer fields to IPNS results
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fields to IPNS results: `record`: present in the return from `ipns.resolve` - contains the resolved IPNS record. `answer`: present in the return from `ipns.resolveDNSLink` - contains the resolved DNS Answer.
achingbrain
changed the title
expires and record/answer fields to IPNS resultsrecord/answer fields to IPNS results
achingbrain
force-pushed
the
feat/add-expires-and-record-field-to-ipns
branch
from
ce6e22b
to
2451c2f
Compare
3 tasks
2color
approved these changes
Mar 14, 2024
|
It's non-breaking because we're just adding some more fields to the return types, rather than removing fields or changing the type from, like string to object or whatever. I mentioned a breaking change on the maintainers call because I mis-remembered us returning strings, turns out we return objects so we're all good. |
SgtPooki
approved these changes
Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fields to IPNS results:
record: present in the return fromipns.resolve- contains the resolved IPNS record.answer: present in the return fromipns.resolveDNSLink- contains the resolved DNS Answer.Change checklist