test(fix): interop UnixFS-chunked JSON file #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Apr 17, 2024
Comment on lines
+297
to
+301
| if (err.code === 'ERR_NO_ROUTERS_AVAILABLE') { | ||
| // need to retry without sessions | ||
| // TODO: handle this better | ||
| return this.handleDagCbor({ resource, cid, path, accept, session: false, cacheKey, options }) | ||
| } |
There was a problem hiding this comment.
AFAICT, there is no way to check this.helia.routing for routers length? feels like this should be handled in helia session management code
| @@ -21,7 +21,7 @@ describe('@helia/verified-fetch - json', () => { | |||
| await loadFixtureDataCar(controller, 'QmQJ8fxavY54CUsxMSx9aE9Rdcmvhx8awJK2jzJp4iAqCr-tokens.uniswap.org-2024-01-18.car') | |||
| verifiedFetch = await createVerifiedFetch({ | |||
| gateways: [`http://${controller.api.gatewayHost}:${controller.api.gatewayPort}`], | |||
| routers: [`http://${controller.api.gatewayHost}:${controller.api.gatewayPort}`] | |||
| routers: [] | |||
There was a problem hiding this comment.
temp fix to stop endless routing caused by ipfs/helia#501
|
this was resolved in #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on top of #55
related: