fix: identity CIDs use contentTypeParser #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Apr 10, 2024
| @@ -97,7 +97,7 @@ | |||
| "@sgtpooki/file-type": "^1.0.1", | |||
| "@types/sinon": "^17.0.3", | |||
| "aegir": "^42.2.5", | |||
| "blockstore-core": "^4.4.0", | |||
| "blockstore-core": "^4.4.1", | |||
There was a problem hiding this comment.
update to get ipfs/js-stores#303
| import Sinon from 'sinon' | ||
| import { fromString as uint8ArrayFromString } from 'uint8arrays/from-string' | ||
| import { createVerifiedFetch } from '../src/index.js' | ||
| import { VerifiedFetch } from '../src/verified-fetch.js' | ||
| import { createHelia } from './fixtures/create-offline-helia.js' |
Comment on lines
+136
to
+146
| it('can properly set content type for identity CIDs', async () => { | ||
| verifiedFetch = new VerifiedFetch({ | ||
| helia | ||
| }, { | ||
| contentTypeParser: async (data) => { | ||
| return 'text/plain' | ||
| } | ||
| }) | ||
| const resp = await verifiedFetch.fetch(CID.parse('bafkqablimvwgy3y')) | ||
| expect(resp.headers.get('content-type')).to.equal('text/plain') | ||
| }) |
| import { MemoryDatastore } from 'datastore-core' | ||
| import type { HeliaHTTPInit } from '@helia/http' | ||
| import type { Helia } from '@helia/interface' | ||
|
|
||
| export async function createHelia (init: Partial<HeliaHTTPInit> = {}): Promise<Helia> { | ||
| const datastore = new MemoryDatastore() | ||
| const blockstore = new MemoryBlockstore() | ||
| const blockstore = new IdentityBlockstore(new MemoryBlockstore()) |
There was a problem hiding this comment.
allow identity blocks when testing
|
CI action hung for some reason. cancelled and restarted |
SgtPooki
deleted the
48-bug-requests-for-identity-cid-is-not-being-handled-properly-anymore
branch
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## @helia/verified-fetch [1.3.9](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-1.3.8...@helia/verified-fetch-1.3.9) (2024-04-11) ### Bug Fixes * identity CIDs use contentTypeParser ([#49](#49)) ([3014498](3014498))
|
🎉 This PR is included in version 1.3.9 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: identity CIDs use contentTypeParser
Description
latest update of
@helia/verified-fetchcaused failing tests in service-worker-gateway: ipfs/service-worker-gateway#187Fixes #48
Notes & open questions
This change normalizes how we handle setting content-type for raw CIDs and identity CIDs and was required to ensure that the content-type is set correctly for identity CIDs.
Change checklist