-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: walking dag-cbor paths #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
@@ -294,6 +324,9 @@ export class VerifiedFetch { | |||
if (options?.signal?.aborted === true) { | |||
throw new AbortError('signal aborted by user') | |||
} | |||
if (['ERR_NO_PROP', 'NO_TERMINAL_ELEMENT'].includes(err.code)) { | |||
return notFoundResponse(resource.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 on bad paths for unixfs now too
this PR is passing on local run of ipfs/helia-http-gateway#67:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, comments inline.
Co-authored-by: Alex Potsides <alex@achingbrain.net>
## @helia/verified-fetch [1.3.7](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-1.3.6...@helia/verified-fetch-1.3.7) (2024-04-08) ### Bug Fixes * walking dag-cbor paths ([#39](#39)) ([99668ce](99668ce))
🎉 This PR is included in version 1.3.7 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.15.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Title
Description
fixes #38
Notes & open questions
Also fixes an issue where we would throw "error walking path" for unixfs CIDs even if we had no error and the path was invalid.
Change checklist