Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change cidv0 to cidv1 in the readme #105

Merged
merged 2 commits into from
Sep 21, 2024
Merged

docs: change cidv0 to cidv1 in the readme #105

merged 2 commits into from
Sep 21, 2024

Conversation

bjesus
Copy link
Contributor

@bjesus bjesus commented Sep 14, 2024

I'm just starting with IPFS, but I'm assuming it's not supposed to say "cidv0 & cidv0"

@bjesus bjesus requested a review from a team as a code owner September 14, 2024 21:35
@bjesus bjesus changed the title change cidv0 to cidv1 in the readme docs: change cidv0 to cidv1 in the readme Sep 15, 2024
@@ -522,7 +522,7 @@ This module attempts to act as similarly to the `fetch()` API as possible.

This library supports the following methods of fetching web3 content from IPFS:

1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv0>`
1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv1>`
Copy link
Member

@2color 2color Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update

* 1. IPFS protocol: `ipfs://<cidv0>` & `ipfs://<cidv0>`
which is the source for the README.md which is generated.

@bjesus
Copy link
Contributor Author

bjesus commented Sep 21, 2024

done, didn't realize the whole README was auto-generated

@2color 2color merged commit 060e726 into ipfs:main Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants