Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: breaking API change from helia broke build #68

Closed
SgtPooki opened this issue May 1, 2024 · 4 comments · Fixed by #70
Closed

bug: breaking API change from helia broke build #68

SgtPooki opened this issue May 1, 2024 · 4 comments · Fixed by #70

Comments

@SgtPooki
Copy link
Member

SgtPooki commented May 1, 2024

on main:

╰─ ✔ ❯ npm i && npm run build
npm WARN deprecated @babel/plugin-proposal-numeric-separator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.
npm WARN deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated @babel/plugin-proposal-optional-catch-binding@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-catch-binding instead.
npm WARN deprecated read-pkg-up@11.0.0: Renamed to read-package-up
npm WARN deprecated @babel/plugin-proposal-logical-assignment-operators@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-logical-assignment-operators instead.
npm WARN deprecated eslint-config-standard-with-typescript@37.0.0: Please use eslint-config-love, instead.
npm WARN deprecated @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
npm WARN deprecated @babel/plugin-proposal-async-generator-functions@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.
npm WARN deprecated querystring@0.2.1: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated @babel/plugin-proposal-object-rest-spread@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated multibase@4.0.6: This module has been superseded by the multiformats module
npm WARN deprecated ipfs-core-utils@0.18.1: js-IPFS has been deprecated in favour of Helia - please see https://github.com/ipfs/js-ipfs/issues/4336 for details
npm WARN deprecated ipfs-core-types@0.14.1: js-IPFS has been deprecated in favour of Helia - please see https://github.com/ipfs/js-ipfs/issues/4336 for details

added 2470 packages, and audited 2680 packages in 35s

372 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> helia-verified-fetch@1.0.0 build
> aegir run build


@helia/verified-fetch: npm run build
@helia/verified-fetch: > @helia/verified-fetch@1.3.13 build
@helia/verified-fetch: > aegir build
@helia/verified-fetch: [14:11:31] tsc [started]
@helia/verified-fetch: src/index.ts(709,11): error TS2353: Object literal may only specify known properties, and 'gateways' does not exist in type 'TrustlessGatewayBlockBrokerInit'.
@helia/verified-fetch: [14:11:32] tsc [failed]
@helia/verified-fetch: [14:11:32] → Command failed with exit code 1: tsc
@helia/verified-fetch: Command failed with exit code 1: tsc
@helia/verified-fetch: npm error Lifecycle script `build` failed with error:
@helia/verified-fetch: npm error Error: command failed
@helia/verified-fetch: npm error   in workspace: @helia/verified-fetch@1.3.13
@helia/verified-fetch: npm error   at location: /Users/sgtpooki/code/work/protocol.ai/ipfs/helia-verified-fetch/packages/verified-fetch
Command failed with exit code 1: npm run build
Command failed with exit code 1: tsc
npm error Lifecycle script `build` failed with error:
npm error Error: command failed
npm error   in workspace: @helia/verified-fetch@1.3.13
npm error   at location: /Users/sgtpooki/code/work/protocol.ai/ipfs/helia-verified-fetch/packages/verified-fetch

> @helia/verified-fetch@1.3.13 build
> aegir build

[14:11:31] tsc [started]
src/index.ts(709,11): error TS2353: Object literal may only specify known properties, and 'gateways' does not exist in type 'TrustlessGatewayBlockBrokerInit'.
[14:11:32] tsc [failed]
[14:11:32] → Command failed with exit code 1: tsc
@SgtPooki
Copy link
Member Author

SgtPooki commented May 1, 2024

FYI this means https://github.com/ipfs/helia/blob/55b96505c4912b61ac87dcd99852176fdc366506/packages/http/README.md?plain=1#L61-L70 is currently broken.. trying to track down where I saw the new way to do this.

SgtPooki added a commit that referenced this issue May 1, 2024
@SgtPooki
tmp: fix for #68
a6edc59
@SgtPooki SgtPooki mentioned this issue May 2, 2024
Merged
@SgtPooki
Copy link
Member Author

SgtPooki commented May 2, 2024

we need to consume the new router from @helia/routing and removing the "gateways" config from trustless gateways:

https://github.com/ipfs/helia-verified-fetch/blob/696ed5735b99262e27710fa382d0905a42b6a386/packages/verified-fetch/src/index.ts#L714C85-L714C105

@SgtPooki
Copy link
Member Author

SgtPooki commented May 2, 2024

We will be reverting the change that went out as a patch and releasing as new version to "do this the right way"

achingbrain added a commit that referenced this issue May 2, 2024
@achingbrain
fix: use http gateway routing
da6ca8c 
Fixes #68
@achingbrain achingbrain mentioned this issue May 2, 2024
Merged
3 tasks
@SgtPooki
Copy link
Member Author

SgtPooki commented May 9, 2024

This was fixed by #50

@SgtPooki SgtPooki closed this as completed May 9, 2024
SgtPooki added a commit that referenced this issue May 9, 2024
@achingbrain @SgtPooki
docs: generate readme (#70)
a75567a 
* fix: use http gateway routing

Fixes #68

* chore: fix linting

* chore: update brokers

* deps: update helia deps

* test: offline custom dns-resolvers test

* test: update verified-fetch in interop test

* fix: prevent interop timeouts with fast fixture loading (#72)

* deps: update ipfsd-ctl and kubo-rpc-client

* chore: apply suggestions from code review

* tmp: get some debug logs from CI jobs

* fix: disable delegated routing in vfetch-interop tests

* fix: test:node on windows

* Revert "tmp: get some debug logs from CI jobs"

This reverts commit 3654a28.

* Revert "fix: prevent interop timeouts with fast fixture loading (#72)"

This reverts commit 2b2e93b.

* tmp: disable node tests on windows

* Revert "tmp: disable node tests on windows"

This reverts commit 186c7c0.

* tmp: enable debug logging for tests...

* Revert "tmp: enable debug logging for tests..."

This reverts commit 21eba60.

* deps: update vfetch in interop package

* chore: apply suggestions from code review

---------

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue May 9, 2024
@semantic-release-bot
chore(release): 1.4.1 [skip ci]
e3c0a68 
## @helia/verified-fetch [1.4.1](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-1.4.0...@helia/verified-fetch-1.4.1) (2024-05-09)

### Documentation

* generate readme ([#70](#70)) ([a75567a](a75567a)), closes [#68](#68) [#72](#72) [#72](#72)
SgtPooki added a commit that referenced this issue May 9, 2024
@SgtPooki
test: add gateway conformance tests (#67)
30958fb 
* feat: initial gateway-conformance setup

* feat: basic subdomain and path requests work

* docs: add debug instructions

* feat: multiple changes and fixes to lint/dep-check

* chore: trying to get passing tests to run is a PITA

* fix: split up conformance tests so its not one big long run

* fix: longer spec test timeout and more accurate fail/pass count

* chore: ensure test:node script exists

* feat: making progress on conformance test running

* feat: gateway-conformance tests are running and passing locally

NOTE: we are failing actual conformance tests, but the tests here ensure no regressions

* tmp: fix for #68

* feat: use gateway-conformance cmd instead of docker

* feat: create github action for running gateway conformance

* fix: gateway conformance action working dir

* fix: remove test:node script so tests aren't run with others because additional setup is required

* fix: json formatting

* fix: tighten up expectations with minSuccesses

* fix: gateway conformance action syntax is correct

* fix: gwc can npm install deps

* chore: gwc gh action caches node modules

* fix: remove mkdir

* chore: update actions/upload-artifact

* test: explicit counts for default gwc specs

* chore: apply suggestions from code review

* test: support IPFS_NS_MAP fixtures

* chore: various fixes

* test: disable ipfs_ns_map in CI
github-actions bot pushed a commit that referenced this issue May 9, 2024
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
ef5b6a5 
## @helia/verified-fetch-gateway-conformance 1.0.0 (2024-05-09)

### Tests

* add gateway conformance tests ([#67](#67)) ([30958fb](30958fb)), closes [#68](#68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: generate readme ipfs/helia-verified-fetch
1 participant
@SgtPooki