fix: walking dag-cbor paths #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Mar 30, 2024
| @@ -294,6 +324,9 @@ export class VerifiedFetch { | |||
| if (options?.signal?.aborted === true) { | |||
| throw new AbortError('signal aborted by user') | |||
| } | |||
| if (['ERR_NO_PROP', 'NO_TERMINAL_ELEMENT'].includes(err.code)) { | |||
| return notFoundResponse(resource.toString()) | |||
There was a problem hiding this comment.
404 on bad paths for unixfs now too
|
this PR is passing on local run of ipfs/helia-http-gateway#67: |
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
achingbrain
reviewed
Apr 5, 2024
Co-authored-by: Alex Potsides <alex@achingbrain.net>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
## @helia/verified-fetch [1.3.7](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-1.3.6...@helia/verified-fetch-1.3.7) (2024-04-08) ### Bug Fixes * walking dag-cbor paths ([#39](#39)) ([99668ce](99668ce))
|
🎉 This PR is included in version 1.3.7 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
fixes #38
Notes & open questions
Also fixes an issue where we would throw "error walking path" for unixfs CIDs even if we had no error and the path was invalid.
Change checklist